Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add unit test for moveColumns with tight maxColumns limit #1189

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

sequba
Copy link
Contributor

@sequba sequba commented Mar 14, 2023

Context

TBP

How did you test your changes?

TBP

Types of changes

  • Breaking change (a fix or a feature because of which an existing functionality doesn't work as expected anymore)
  • New feature or improvement (a non-breaking change that adds functionality)
  • Bug fix (a non-breaking change that fixes an issue)
  • Additional language file, or a change to an existing language file (translations)
  • Change to the documentation

Related issues:

#1185

Checklist:

  • My change is compliant with the OpenDocument standard.
  • My change is compatible with Microsoft Excel.
  • My change is compatible with Google Sheets.
  • My code follows the code style of this project.
  • I described my changes in the CHANGELOG.md file.
  • My changes require a documentation update.
  • My changes require a migration guide.

@sequba sequba marked this pull request as draft March 14, 2023 13:14
@sequba sequba self-assigned this Mar 14, 2023
@github-actions
Copy link

github-actions bot commented Mar 14, 2023

Performance comparison of head (30db0f3) vs base (bc23b98)

                                     testName |  base |  head |  change
-----------------------------------------------------------------------
                                      Sheet A | 618.5 | 637.5 |  +3.07%
                                      Sheet B | 269.3 | 270.6 |  +0.48%
                                      Sheet T |   309 | 316.9 |  +2.56%
                                Column ranges | 733.1 | 762.5 |  +4.01%
Sheet A:  change value, add/remove row/column |    40 |    44 | +10.00%
 Sheet B: change value, add/remove row/column |   350 |   357 |  +2.00%
                   Column ranges - add column |   272 |   260 |  -4.41%
                Column ranges - without batch |   712 |   591 | -16.99%
                        Column ranges - batch |   380 |   182 | -52.11%

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant