Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix registerLanguage() issue in the code examples #1484

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Conversation

sequba
Copy link
Contributor

@sequba sequba commented Jan 15, 2025

Context

Code examples now check for registered languages before registering new ones.

How did you test your changes?

local docs build

Types of changes

  • Breaking change (a fix or a feature because of which an existing functionality doesn't work as expected anymore)
  • New feature or improvement (a non-breaking change that adds functionality)
  • Bug fix (a non-breaking change that fixes an issue)
  • Additional language file, or a change to an existing language file (translations)
  • Change to the documentation

Related issues:

  1. Fixes [Bug]: Language already registered error in the i18n demo when switching between docs pages #1481

Checklist:

  • I have reviewed the guidelines about Contributing to HyperFormula and I confirm that my code follows the code style of this project.
  • I have signed the Contributor License Agreement.
  • My change is compliant with the OpenDocument standard.
  • My change is compatible with Microsoft Excel.
  • My change is compatible with Google Sheets.
  • I described my changes in the CHANGELOG.md file.
  • My changes require a documentation update.
  • My changes require a migration guide.

@sequba sequba marked this pull request as ready for review January 15, 2025 11:09
@sequba sequba self-assigned this Jan 15, 2025
@sequba sequba requested a review from budnix January 15, 2025 11:10
Copy link

github-actions bot commented Jan 15, 2025

Performance comparison of head (43713d9) vs base (cdb234e)

                                     testName |   base |   head |  change
-------------------------------------------------------------------------
                                      Sheet A | 537.09 | 509.87 |  -5.07%
                                      Sheet B | 182.43 | 165.41 |  -9.33%
                                      Sheet T | 156.95 | 146.68 |  -6.54%
                                Column ranges | 532.24 | 514.99 |  -3.24%
Sheet A:  change value, add/remove row/column |  16.22 |  14.51 | -10.54%
 Sheet B: change value, add/remove row/column | 134.05 | 129.79 |  -3.18%
                   Column ranges - add column | 156.52 | 151.63 |  -3.12%
                Column ranges - without batch | 468.84 | 456.75 |  -2.58%
                        Column ranges - batch | 118.46 | 114.92 |  -2.99%

@sequba sequba merged commit 94dd0db into develop Jan 15, 2025
24 checks passed
@sequba sequba deleted the feature/issue-1481 branch January 15, 2025 11:27
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.22%. Comparing base (cdb234e) to head (43713d9).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1484   +/-   ##
========================================
  Coverage    97.22%   97.22%           
========================================
  Files          169      169           
  Lines        14523    14523           
  Branches      3080     3080           
========================================
  Hits         14120    14120           
  Misses         403      403           

sequba added a commit that referenced this pull request Jan 15, 2025
… (#1487)

* Fix registerLanguage() issue in the code examples (#1484)

Make code examples check for registered languages before registering new ones

* Fix mortgage calculator demo error `Cannot load native addon because loading addons is disabled` (#1486)

Migrate mortgage-calculator demo in readme from Codestandbox to Stackblitz
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Language already registered error in the i18n demo when switching between docs pages
2 participants