Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Backend: Renderable Test Suit #3504

Open
wants to merge 3 commits into
base: beta
Choose a base branch
from

Conversation

Thunderblade73
Copy link
Contributor

@Thunderblade73 Thunderblade73 commented Feb 26, 2025

What

Added a good way to add tests for renderables.
The test can be toggled with the /shrenderable ... ingame inside the dev enviroment.

This moved the to renderable test we had inside SkyHanniDebugAndTest and also added the scrollable test which I used to test the new scrollable renderable.

Also added GuiRenderEvent.GuiOnTopRenderEvent. (This event should be used instead of the GuiRender, which renders twice inside the Inventory, but that change should be done at a later point, since it is outside of the scope of this pr)
And proper docs for the Gui Events.

Changelog Technical Details

  • Added Renderable Test Suit. - Thunderblade73
    • A way to add tests for renderables. Which can be called activated with /shrenderable.

@github-actions github-actions bot added Backend A backend pull request that will be merged soon Wrong Title/Changelog There is an error in the title or changelog labels Feb 26, 2025
Copy link

I have detected some issues with your pull request:

Body issues:
Change should end with a full stop in text: A way to add tests for renderables. Which can be called activated with /shrenderable

Please fix these issues. For the correct format, refer to the pull request template.

@github-actions github-actions bot added Detekt Has detekt problem and removed Wrong Title/Changelog There is an error in the title or changelog labels Feb 26, 2025
Copy link

6 Detekt Failures were detected:

@github-actions github-actions bot removed the Detekt Has detekt problem label Feb 26, 2025
@hannibal002 hannibal002 added this to the 3.0.0 milestone Feb 28, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Backend A backend pull request that will be merged soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants