Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Feature + Backend: Sirih Helper #3525

Open
wants to merge 7 commits into
base: beta
Choose a base branch
from

Conversation

ksndq
Copy link

@ksndq ksndq commented Mar 5, 2025

What

Show a clickable message that grabs sulphur from your sacks when talking to Sirih while he is a pig.

Changelog New Features

  • Added Sirih NPC Helper. - ksndq
    • Show a clickable message that grabs sulphur from your sacks when talking to Sirih while he is a pig.

Changelog Technical Details

  • Made PabloHelper use RepoPattern. - ksndq

@ksndq ksndq marked this pull request as ready for review March 5, 2025 23:39
@github-actions github-actions bot added the Wrong Title/Changelog There is an error in the title or changelog label Mar 5, 2025
Copy link

github-actions bot commented Mar 5, 2025

I have detected some issues with your pull request:

Body issues:
Change should end with a full stop in text: Added Sirih NPC Helper

Please fix these issues. For the correct format, refer to the pull request template.

@github-actions github-actions bot added Detekt Has detekt problem and removed Wrong Title/Changelog There is an error in the title or changelog labels Mar 6, 2025
Copy link

github-actions bot commented Mar 6, 2025

2 Detekt Failures were detected:

@github-actions github-actions bot removed the Detekt Has detekt problem label Mar 6, 2025
@ksndq ksndq requested a review from j10a1n15 March 6, 2025 20:20
@ksndq ksndq changed the title Feature: Sirih Helper Feature + Fix: Sirih Helper Mar 6, 2025
@github-actions github-actions bot added the Bug Fix Bug fixes label Mar 6, 2025
@github-actions github-actions bot added the Wrong Title/Changelog There is an error in the title or changelog label Mar 6, 2025
Copy link

github-actions bot commented Mar 6, 2025

I have detected some issues with your pull request:

Title issues:
PR has category 'Fix' which is not in the changelog. Expected categories: Feature

Please fix these issues. For the correct format, refer to the pull request template.

@ksndq ksndq requested a review from j10a1n15 March 6, 2025 20:24
Copy link

github-actions bot commented Mar 6, 2025

I have detected some issues with your pull request:

Body issues:
Unknown line after changes started being declared in text: *

Please fix these issues. For the correct format, refer to the pull request template.

@github-actions github-actions bot removed the Wrong Title/Changelog There is an error in the title or changelog label Mar 6, 2025
@ksndq ksndq changed the title Feature + Fix: Sirih Helper Feature + Backend: Sirih Helper Mar 6, 2025
@github-actions github-actions bot added Backend A backend pull request that will be merged soon and removed Bug Fix Bug fixes labels Mar 6, 2025
Copy link
Contributor

@j10a1n15 j10a1n15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Backend A backend pull request that will be merged soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants