Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Publish dew point approximation to mqtt #130

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

micampe
Copy link
Contributor

@micampe micampe commented Jan 23, 2021

Dew point is a more interesting value to assess human comfort than just pure temperature and humidity, this change calculates an approximation and publishes it to an mqtt topic.

Elgato Eve supports a custom characteristic for dew point as well, so it could be published there too.

Note that this change depends on my previous pull request for the configuration UI #129.

@micampe micampe force-pushed the dew-point branch 3 times, most recently from 21d6164 to 6b799b8 Compare January 23, 2021 09:13
@hannseman
Copy link
Owner

hannseman commented Apr 17, 2021

Many thanks for you PR. I think it would be interesting to add the dew point characteristic, would you like to add it?

I also think that we should add new methods for "setting" and getting the dewPoint instead of using the setter/getter pairs for humidity and temperature. So on scanner.on("temperatureChange") and scanner.on("humidityChange") we could use a new method called setDewPoint() or updateDewPoint() which would use your dewPoint getter to publish the value on the MQTT-topic and update the elgato characteristic. What do you think?

@micampe
Copy link
Contributor Author

micampe commented Apr 19, 2021

Yes, that seems very reasonable. I can do it but I’m not very fluent in js/node and currently busy with other things so I’m not sure I’ll be able to pick it back up.

@hannseman
Copy link
Owner

@micampe no worries, I'll try to find the time to bring it over the finish line. Thanks for your input and effort!

@github-actions
Copy link

File Coverage Lines Branches Missing
All files 100% 100% 100%

Minimum allowed coverage is 100%

Generated by 🐒 cobertura-action against 9911ce9

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants