Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

createAuthCredential for Google Provider type had mismatched parameters #18

Merged
merged 1 commit into from
Nov 27, 2020
Merged

createAuthCredential for Google Provider type had mismatched parameters #18

merged 1 commit into from
Nov 27, 2020

Conversation

grantges
Copy link
Contributor

  • iOS: createAuthCredential for Google was incorrect. required parameters are the IDToken and the AccessToken
  • Android: createAuthCredential for Google was incorrect. required parameters are the IDToken and the AccessToken

@grantges
- iOS: createAuthCredential for Google was incorrect. required parame…
0b02175 
…ters are the IDToken and the AccessToken

- Android: createAuthCredential for Google was incorrect. required parameters are the IDToken and the AccessToken
@grantges
Copy link
Contributor Author

If you look at the function for creating the googleAuthProvider credential - it requires the IDToken and the access token.

The calls to the underlying native lib were passing in the accessToken and the secretToken There is no secretToken returned from the google #. Only IDToken and accessToken.

hansemannn
hansemannn approved these changes Nov 27, 2020
View reviewed changes
Copy link
Owner

@hansemannn hansemannn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

@hansemannn hansemannn merged commit e8a4af2 into hansemannn:master Nov 27, 2020
@hansemannn
Copy link
Owner

Release: https://github.com/hansemannn/titanium-firebase-auth/releases/tag/ios-3.0.0

@grantges
Copy link
Contributor Author

@hansemannn - getting an error when trying to compile with that latest release.

[ERROR] ** BUILD FAILED **
[ERROR] The following build commands failed:
[ERROR] Ld /Users/bert/Repos/titanium/FirebaseTestApp/build/iphone/build/Intermediates/FirebaseTestApp.build/Debug-iphonesimulator/FirebaseTestApp.build/Objects-normal/x86_64/Binary/FirebaseTestApp normal x86_64
[ERROR] (1 failure)

Process exited with 1

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@hansemannn hansemannn hansemannn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grantges @hansemannn