Cleanup for #266

hapijs · Mar 12, 2020 · 703ba07 · 703ba07
1 parent 7e4dcd2
commit 703ba07
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/lib/index.js b/lib/index.js
@@ -98,7 +98,7 @@ exports.Boom = class extends Error {
 
 exports.isBoom = function (err, statusCode) {
 
-    return err instanceof Error && !!err.isBoom && (statusCode ? err.output.statusCode === statusCode : true);
+    return err instanceof Error && !!err.isBoom && (!statusCode || err.output.statusCode === statusCode);
 };
 
 

diff --git a/test/index.ts b/test/index.ts
@@ -58,8 +58,10 @@ expect.type<boolean>(Boom.boomify(error).isBoom);
 // isBoom()
 
 expect.type<boolean>(Boom.isBoom(error));
+expect.type<boolean>(Boom.isBoom(error, 404));
 expect.type<boolean>(Boom.isBoom(Boom.boomify(error)));
 
+expect.error(Boom.isBoom(error, 'test'));
 expect.error(Boom.isBoom('error'));
 expect.error(Boom.isBoom({ foo: 'bar' }));
 expect.error(Boom.isBoom({ error: true }));
-Original file line number
+Diff line change
@@ Expand Up / @@ -98,7 +98,7 @@ exports.Boom = class extends Error { @@
     exports.isBoom = function (err, statusCode) {
-        return err instanceof Error && !!err.isBoom && (statusCode ? err.output.statusCode === statusCode : true);
+        return err instanceof Error && !!err.isBoom && (!statusCode || err.output.statusCode === statusCode);
     };
@@ Expand Down @@