lib: add new globals from Node.js 15.x #997
Conversation
This avoids lab failing with Leak errors.
There was a problem hiding this comment.
Thanks @MylesBorins for the PR. Let's wait for the EOW then.
Co-authored-by: Richard Lau <rlau@redhat.com>
|
This seems good to go now 🎉 |
There was a problem hiding this comment.
This looks good, but npm@7 that goes with node@15 is not compatible with lab.
The error from CI is:
45 verbose stack TypeError: Cannot read property 'version' of undefined
45 verbose stack at Arborist.[saveIdealTree] (/home/node-15/.nvm/versions/node/v15.0.0/lib/node_modules/npm/node_modules/@npmcli/arborist/lib/arborist/reify.js:800:33)
45 verbose stack at /home/node-15/.nvm/versions/node/v15.0.0/lib/node_modules/npm/node_modules/@npmcli/arborist/lib/arborist/reify.js:124:39
45 verbose stack at async Arborist.reify (/home/node-15/.nvm/versions/node/v15.0.0/lib/node_modules/npm/node_modules/@npmcli/arborist/lib/arborist/reify.js:121:5)
45 verbose stack at async install (/home/node-15/.nvm/versions/node/v15.0.0/lib/node_modules/npm/lib/install.js:40:5)
It seems that this is because it chooses not to install the 'typescript' dependency. And fails somehow when trying again.
|
@kanongil looking into the npm 7 error now |
|
@MylesBorins I suspect it's the same issue as npm/cli#1998. |
|
FWIW I'm able to install/test lab with npm@7 with |
|
I made an npm issue here: npm/cli#2005. It does not appear to be the same as npm/cli#1998. |
|
These changes are now published as 24.1.0. Thank you for the help! |
This avoids lab failing with Leak errors.
There might be a few other globals that get introduced, not 100%. Might make sense to wait until EOW to confirm the globals.