Skip to content

Release version 4.3.0 #1688

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Release version 4.3.0 #1688

merged 1 commit into from
Nov 16, 2023

Conversation

hardbyte
Copy link
Owner

Updates the version to v4.3.0. Feel free to push changes to the changelog directly to this branch.

@hardbyte hardbyte requested a review from lumagi November 10, 2023 04:42
@lumagi
Copy link
Collaborator

lumagi commented Nov 11, 2023

This merges into develop. I think develop now contains two more merged PRs than the release candidate. Should they also be included in the 4.3.0 release, or only the features of the candidate?

@zariiii9003
Copy link
Collaborator

Should they also be included in the 4.3.0 release, or only the features of the candidate?

Yes, please include those.

@zariiii9003
Copy link
Collaborator

The changelog should be up to date already

Copy link
Collaborator

@lumagi lumagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zariiii9003 You're right, I was a little confused when I wanted to add the entries to the Changelog just now :D

@NixonLuka
Copy link

Can't wait for this to get merged so I can use v4.3.0 😄 It's got just the bug fix I need!

@hardbyte hardbyte changed the base branch from develop to main November 16, 2023 21:26
@hardbyte hardbyte changed the base branch from main to develop November 16, 2023 21:28
@hardbyte
Copy link
Owner Author

This merges into develop. I think develop now contains two more merged PRs than the release candidate. Should they also be included in the 4.3.0 release, or only the features of the candidate?

I think we should abandon the pretense of a "stable" main branch and unstable develop and just have one. I'll merge this into develop and release, then perhaps we delete the current year old main branch and rename develop to main to line up with the majority of current projects.

@hardbyte hardbyte merged commit bc3f955 into develop Nov 16, 2023
@mergify mergify bot deleted the release-4.3.0 branch November 16, 2023 21:31
@zariiii9003
Copy link
Collaborator

I think we should abandon the pretense of a "stable" main branch and unstable develop and just have one. I'll merge this into develop and release, then perhaps we delete the current year old main branch and rename develop to main to line up with the majority of current projects.

I agree. One main branch is sufficient. Bugfixes can always be backported to and released from a minor version branch like release-4.3

@hardbyte
Copy link
Owner Author

I've made that change.

Devs may have to update local environments to target main instead:

git branch -m develop main
git fetch origin
git branch -u origin/main main
git remote set-head origin -a

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants