Add feature to save the image source page URL #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cslite Thanks for the PR. This is definitely going to be useful. But I see no reason why the local path of the image cannot be added along with extract_metadata flag since the source URL of the image is already present. Advantages of having local image path in the extract_metadata json file:
I am merging this PR now but we might plan to merge these two features going forward. :) |
SecorD0
pushed a commit
to SecorD0/google-images-download
that referenced
this pull request
Dec 2, 2022
* Add feature to save image source page url * update README
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, the source page URL of the image is desired. So, I have added it as an additional feature. It creates a text file containing list with local path of downloaded image and source page URL of that image.