Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Double-click the panel to unmaximize the top-most, maximized window. #221

Merged
merged 1 commit into from
Feb 1, 2021
Merged

Double-click the panel to unmaximize the top-most, maximized window. #221

merged 1 commit into from
Feb 1, 2021

Conversation

Leleat
Copy link
Contributor

@Leleat Leleat commented Feb 1, 2021

Closes #89.

I used the button-press-event on the panel to implement this feature. But that would also unmaximize a window when quickly opening and closing a menu in the top panel. In the end I just checked, if the mouse click happened in the Main.panel._leftBox, Main.panel._centerBox or Main.panel._rightBox. Maybe there is a better way?

I tried to follow the convention from the implementation of the other features. But I didn't extend from PanelExtension since this feature is unrelated to a setting / is always-on. I just named the methods activate and destroy. Hope that's fine.

@jonian
Copy link
Member

jonian commented Feb 1, 2021

Hi @Leleat, this looks very good to me. Thank you for your contribution!

@jonian jonian merged commit 20fed2e into hardpixel:master Feb 1, 2021
@Leleat Leleat deleted the dbl-click-to-unmaximize branch February 1, 2021 23:53
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Double click on maximized title bar should restore window size
2 participants