Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Moved several consensus fields to state struct. #4825

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

Frozen
Copy link
Contributor

@Frozen Frozen commented Jan 1, 2025

Motivation:
Refactored the consensus module by splitting it into smaller, modular structs to enhance testability and maintainability.

Results:

  • Increased test coverage for consensus statements from 15% to 18%.
  • Successfully addressed and validated corner cases through comprehensive testing.

@Frozen Frozen self-assigned this Jan 1, 2025
@Frozen Frozen added refactor refactor ready-to-merge test-coverage increased tests coverage labels Jan 11, 2025
@sophoah
Copy link
Contributor

sophoah commented Jan 29, 2025

@GheisMohammadi please review

@Frozen Frozen force-pushed the feature/from-consensus-to-state branch from 3d900f3 to a93be2e Compare January 31, 2025 04:00
@sophoah sophoah merged commit e4ce1ac into dev Jan 31, 2025
4 checks passed
@sophoah sophoah deleted the feature/from-consensus-to-state branch January 31, 2025 06:46
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
ready-to-merge refactor refactor test-coverage increased tests coverage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants