-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: store localnet logs between runs #4830
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frozen
approved these changes
Jan 15, 2025
sophoah
reviewed
Jan 16, 2025
sophoah
reviewed
Jan 16, 2025
1f5ee4d
to
7ceeb50
Compare
|
sophoah
reviewed
Jan 22, 2025
Hey @sophoah, how did you face this? |
just start the localnet, it doesn't happen all the time i tried |
7ceeb50
to
28773b9
Compare
Details: - change rm and clean commands to remove only subfolder for tmp_log folder- justification - tmp_log folder needed for the log aggregator, prevent removal on the go when log stack is running - fix promtail config to point it to the right place - add named volume to the docker-compose to store Loki indexed between localnet runs - echance debug-start-log - it checking that localnet is running, exits if not - add debug-delete-volume-log to make, it removes loki named volume, warns about sudo rm for the loki files
…ig to ingesting huge amount of logs
28773b9
to
2cda0ae
Compare
Fixed in 2cda0ae commit Proof - 150 MB/700K lines of logs ingested in a meter of 1-2 minutes and no more 429 errors in the logs: |
sophoah
approved these changes
Jan 27, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was done:
if not
warns about sudo rm for the loki files
UPD by 24 Jan:
Issue
Test
Main use case:
make debug-ext
or similiar{filename=~"/var/log/log-20250116-195803/.*"}
make clean debug-ext
{filename=~"/var/log/log-20250116-205803/.*"}
Tested commands
Unit Test Coverage
Before:
After:
Test/Run Logs
Operational Checklist
Does this PR introduce backward-incompatible changes to the on-disk data structure and/or the over-the-wire protocol?. (If no, skip to question 8.)
YES|NO
Describe the migration plan.. For each flag epoch, describe what changes take place at the flag epoch, the anticipated interactions between upgraded/non-upgraded nodes, and any special operational considerations for the migration.
Describe how the plan was tested.
How much minimum baking period after the last flag epoch should we allow on Pangaea before promotion onto mainnet?
What are the planned flag epoch numbers and their ETAs on Pangaea?
What are the planned flag epoch numbers and their ETAs on mainnet?
Note that this must be enough to cover baking period on Pangaea.
What should node operators know about this planned change?
Does this PR introduce backward-incompatible changes NOT related to on-disk data structure and/or over-the-wire protocol? (If no, continue to question 11.)
YES|NO
Does the existing
node.sh
continue to work with this change?What should node operators know about this change?
Does this PR introduce significant changes to the operational requirements of the node software, such as >20% increase in CPU, memory, and/or disk usage?
TODO