Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Improve multiple propose at epoch change #4837

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

Frozen
Copy link
Contributor

@Frozen Frozen commented Jan 23, 2025

Fix for doulbe proposing on epoch change.

Note:

  1. tested with legacy sync only
  2. better contains this change to reduce side effects

@Frozen Frozen self-assigned this Jan 23, 2025
@sophoah sophoah changed the title Fix for doulbe proposing on the epoch change. Fix for double proposing on the epoch change. Jan 24, 2025
@sophoah
Copy link
Contributor

sophoah commented Jan 24, 2025

it's not perfect but i am at epoch 78 and there was no consensus loss running with make debug-multi-bls-multi-ext-node. However we still have two async proposal as per screenshot
image

@sophoah
Copy link
Contributor

sophoah commented Jan 24, 2025

@GheisMohammadi please review/approve

@sophoah sophoah changed the title Fix for double proposing on the epoch change. Fix for double proposing on the epoch change Jan 27, 2025
@sophoah sophoah changed the title Fix for double proposing on the epoch change Improve multiple propose at epoch change Jan 27, 2025
@sophoah sophoah merged commit fa0422a into dev Jan 27, 2025
4 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants