Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix make debug-multi-bls without external #4842

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

sophoah
Copy link
Contributor

@sophoah sophoah commented Feb 5, 2025

Issue

The local network experiences a consensus loss at the first block of epoch 2 when configured with test/config/local-multi-bls.txt.

This is due to an existing bug in the consensus protocol, which incorrectly assumes the presence of 9 BLS keys per shard. This pull request introduces the missing BLS key to circumvent the bug and maintain consensus.

Without external will eventually be used by the harmony-test repo when running the CI test

tests

Running localnet local-multi-bls.txt without creating the external validator

./test/debug.sh ./test/configs/local-multi-bls.txt 64 64  

epoch has 2 starts at 70 and below are the HOORAY logs

{"level":"info","port":"9000","ip":"127.0.0.1","shardID":0,"myBlock":69,"myViewID":69,"phase":"Announce","mode":"Normal","blockNum":68,"epochNum":1,"ViewId":68,"blockHash":"0xcb70d3c57439f69ac65a7d0f8b578ec2b4e978e7b946a39a13d10f63c2fdf40c","numTxns":0,"numStakingTxns":0,"caller":"/home/soph/harmony/harmony/consensus/consensus_v2.go:283","time":"2025-02-05T14:17:34.895140513+07:00","message":"HOORAY!!!!!!! CONSENSUS REACHED!!!!!!!"}
{"level":"info","port":"9000","ip":"127.0.0.1","shardID":0,"myBlock":70,"myViewID":70,"phase":"Announce","mode":"Normal","blockNum":69,"epochNum":2,"ViewId":69,"blockHash":"0xd50ca9e69b0635149d01f8d504a5f03455d30e8d954714dc6cde15e3baa4724b","numTxns":0,"numStakingTxns":0,"caller":"/home/soph/harmony/harmony/consensus/consensus_v2.go:283","time":"2025-02-05T14:17:36.894093077+07:00","message":"HOORAY!!!!!!! CONSENSUS REACHED!!!!!!!"}
{"level":"info","port":"9000","ip":"127.0.0.1","shardID":0,"myBlock":71,"myViewID":71,"phase":"Announce","mode":"Normal","blockNum":70,"epochNum":2,"ViewId":70,"blockHash":"0x86e3dbf7e42259607dd0393040ddad16f0b9ba1fc6364cc168f992f0ea047c72","numTxns":0,"numStakingTxns":0,"caller":"/home/soph/harmony/harmony/consensus/consensus_v2.go:283","time":"2025-02-05T14:17:38.892408281+07:00","message":"HOORAY!!!!!!! CONSENSUS REACHED!!!!!!!"}

Previously, the consensus will stop at block 69

@sophoah sophoah merged commit 76607e5 into harmony-one:dev Feb 5, 2025
3 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants