Fix effective gas price for rpc getTransactionReceipt #4844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophoah
reviewed
Feb 14, 2025
| @@ -390,6 +417,11 @@ func NewStakingTxReceipt( | |||
| return nil, err | |||
| } | |||
|
|
|||
| effectiveGasPrice := *big.NewInt(0) | |||
| if receipt.EffectiveGasPrice != nil { | |||
There was a problem hiding this comment.
We should add an else clause to prevent the RPC to returns an effective gas price of 0. Not sure what edge case we are going to have in this case.
There was a problem hiding this comment.
Hey @Frozen I've tested against old and new transactions against testnet RPC and found that rn we still have 2 behaviors:
- old transactions have "effectiveGasPrice": 0
- new transactions have effectiveGasPrice==gasUsed
Can we make the same behavior effectiveGasPrice==gasUsed for the old transactions?
sophoah
reviewed
Feb 14, 2025
Frozen
force-pushed
the
fix/rpc-effetive-gas-price
branch
from
460c1a6 to
6f126d8
Compare
GheisMohammadi
approved these changes
Feb 20, 2025
|
returns |
sophoah
changed the title
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue with effective gas price panic. Covered wth tests.