Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Using certain filters on an undefined variable will throw an error #140

Closed
robinbijlani opened this issue Jul 18, 2019 · 0 comments
Closed
Assignees
Labels

Comments

@robinbijlani
Copy link
Contributor

Thank you for the great package! 🙇‍♀

I did run into a situation which I think may be a bug:

If you use any of the following filters on an undefined variable, they will throw an error:

  • capitalize
  • downcase
  • size
  • remove
  • first
  • last

Example: https://jsfiddle.net/wxekqcnp/3/

I would not expect this to happen because with the default options, an undefined variable should evaluate to an empty string, and these filters all work fine on an empty string:
Example: https://jsfiddle.net/wxekqcnp/2/

Do I misunderstand the intended behavior, or is this a bug?

@harttle harttle added the bug label Jul 22, 2019
@harttle harttle self-assigned this Jul 22, 2019
harttle pushed a commit that referenced this issue Jul 22, 2019
## [8.4.1](v8.4.0...v8.4.1) (2019-07-22)

### Bug Fixes

* some filters on undefined variable throws, [#140](#140) ([6e6ea0a](6e6ea0a))
@harttle harttle closed this as completed Jul 22, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants