[Travis] Allow detached head when parsing master ref. #2286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we have checked out a commit instead of a branch name, git is in what’s known as “detached head” state. This is what Travis does all the time. This means that we were never considered to be on the branch “master”, and therefore were never publishing bower-chosen. We can tweak the git command we’re calling to support either checked out branch names or detached heads — as long as we’re at the commit for a commit that is the head of master, we’re peachykeen!
|
👍 boom. Thanks, @adunkman!!!! |
pfiller
added a commit
that referenced
this pull request
Mar 28, 2015
[Travis] Allow detached head when parsing master ref.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@harvesthq/chosen-developers
If we have checked out a commit instead of a branch name, git is in what’s known as “detached head” state.
This is what Travis does all the time — see the latest build output.
This means that we were never considered to be on the branch “master”, and therefore were never publishing bower-chosen.
We can tweak the git command we’re calling to support either checked out branch names or detached heads — as long as we’re at the commit for a commit that is the head of master, we’re peachykeen!