Don't open up chosen on option keyup. #2475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When embedding chosen in a chrome extension, the keyboard shortcut includes the option key. If a chosen instance happens to be focused at the time, releasing the option key opens it, but shouldn't.
|
👍 LGTM B-RAD. |
tjschuck
added a commit
that referenced
this pull request
Nov 10, 2015
Don't open up chosen on option keyup.
|
(Draft release notes updated.) |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Chosen!
When embedding chosen in a chrome extension, the keyboard shortcut includes the option key. If a chosen instance happens to be focused at the time, releasing the option key opens it, but shouldn't. This patch ignores option keyup events.
I ran the build task after making the change like it says to in
contributing.md, but it didn't change any git-tracked files that I could tell. Let me know if I need to do something else!