Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove height clobbering for chosen-choices #2498

Merged
merged 1 commit into from
Feb 24, 2016

Conversation

bronzehedwick
Copy link
Contributor

This seems like an IE6 hack, but IE6 usage is very low, and it nukes height resets with !important for every other browser.

This seems like an IE6 hack, but IE6 usage is very low, and it nukes `height` resets with `!important` for every other browser.
@tjschuck
Copy link
Member

tjschuck commented Jan 7, 2016

IE6 isn't supported, so if it is an IE6 hack, removing it should be okay.

IE support goes back as far as IE8. See http://harvesthq.github.io/chosen/#faqs

@tjschuck
Copy link
Member

tjschuck commented Jan 7, 2016

/cc @mlettini

@mlettini
Copy link
Contributor

mlettini commented Jan 7, 2016

This does seem like a safe thing to do. I'll also need to make this change in #2479 which I haven't picked back up yet.

@bronzehedwick
Copy link
Contributor Author

Just checking in on this issue - is merging this PR in blocked by #2479 ?

@tjschuck
Copy link
Member

@bronzehedwick In my opinion, it shouldn't be. #2479 is effectively setting the stage for a 2.0 release, and this seems like a bug that affects the current versions and should be handled accordingly.

If @mlettini @stof or @koenpunt gives the 👍, they can go ahead and merge it with my blessing!

Particularly cc: @stof who is usually the expert on our legacy IE support.

@koenpunt
Copy link
Collaborator

Looks sensible 👍

tjschuck added a commit that referenced this pull request Feb 24, 2016
Remove height clobbering for chosen-choices
@tjschuck tjschuck merged commit 2a90659 into harvesthq:master Feb 24, 2016
@tjschuck
Copy link
Member

Thanks @bronzehedwick !

@bronzehedwick
Copy link
Contributor Author

💯 Thanks!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants