add hide_results_on_select option #2687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hide_results_on_select will default to true, to keep it backwards compatible. fixes #1546
|
Seems okay to me 👍 Up to you if you want a better 👍 than mine 😜 |
|
I've drafted a release as 1.7.0 (minor b/c new feature). Are you aware of other fixes that we could include in this release? Or should we just release it? |
|
+1 for release it |
|
1.7.0 has just been released |
|
I like hide_results_on_select option but it always scrolls back to the top and I always have to find my place near the bottom or middle again. Is there any way to keep where you are so you can easily pick all the options you need ? |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hide_results_on_select will default to true, to keep it backwards compatible.
the change is quite trivial, but the demand for it is high, so we might consider adding this?
cc: @pfiller @tjschuck @stof
fixes #1546