Fix escaping in group names, no results message. #2879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That before/after table is a thing of beauty, @adunkman 😻 |
satchmorun
approved these changes
Aug 31, 2017
tjschuck
reviewed
Aug 31, 2017
spec/proto/searching.spec.coffee
Outdated
| @@ -28,3 +28,72 @@ describe "Searching", -> | |||
|
|
|||
| results = div.select(".active-result") | |||
| expect(results.length).toBe(0) | |||
|
|
|||
|
|
|||
This results in double-escaping of group labels.
adunkman
force-pushed
the
escaping-fixes
branch
from
ecfb9c3
to
538a832
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@harvesthq/chosen-developers
Surprisingly, I don’t think I found any issues in this repo for this one — but we’re incorrectly escaping group names and the no results message in some cases:
Test cases included.