Add an option to disable search in each word. #824
Conversation
| @@ -410,6 +410,7 @@ class Chosen extends AbstractChosen | |||
|
|
|||
| results = 0 | |||
|
|
|||
| split_words = !this.options.do_not_split | |||
There was a problem hiding this comment.
You should handle the option in AbstractChosen like others, to allow handling the default value.
And do_not_split does not seem a good name to me. What it is about ? Existing options related to configuring the search are all using search in their name (disable_search, search_contains, disable_search_threshold)
|
When searching search text in each option html, chosen first runs a regex on the whole option html, then , if not found on each separate word. The aim of the option is to disable this second search pass when not necessary or even unwanted. |
| @@ -30,6 +30,7 @@ class AbstractChosen | |||
| @allow_single_deselect = if @options.allow_single_deselect? and @form_field.options[0]? and @form_field.options[0].text is "" then @options.allow_single_deselect else false | |||
| @disable_search_threshold = @options.disable_search_threshold || 0 | |||
| @disable_search = @options.disable_search || false | |||
| @search_split_words = not (@options.disable_search_split_words || false) | |||
There was a problem hiding this comment.
This is a little awkward, but I think that's my fault. Given how other options work, I think this is a pretty fair compromise.
There was a problem hiding this comment.
why not calling the option enable_search_split_words or something like that ? we already have afffirmative names, for instance allow_single_deselect
There was a problem hiding this comment.
I chose "disable" in order to keep current behaviour on default false value. But as noted, it can be changed, considering also other search options like @search_contains.
There was a problem hiding this comment.
I agree - we could have done this a little simpler. Opened a PR #940
|
Thanks @Goutet. This is an interesting option that might help improve performance for some users. I wonder if it should always be true if |
Allow to disable the search on each separate word in an option text.
All js files generated using cake and uglify.