update kill storage #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tlacloc
commented
Sep 22, 2023
•
tlacloc
commented
- Updated the kill_storage function to take an argument to specify what to delete
- Modified the cancel_offer function to require the who parameter and added a check to ensure the caller is a valid admin or owner of the offer
- Added a new enum KillStorageArgs with variants for different types of storage
…ter for more granular control over storage deletion ✨ feat(afloat): add `KillStorageArgs` enum to specify different types of storage to be deleted in `kill_storage` function
…ion to ensure only admin or offer creator can cancel the offer 🐛 fix(lib.rs): remove redundant authorization check in cancel_offer function
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -859,11 +859,14 @@ impl<T: Config> Pallet<T> { | |||
| Ok(()) | |||
| @@ -255,11 +255,40 @@ pub mod pallet { | |||
|
|
|||
There was a problem hiding this comment.
GPT summary of d1cb4c - d1cb4c:
- Added a new argument
argstokill_storagefunction - Removed the check for admin/owner from
cancel_offerfunction - Added logic to
kill_storagefor different types of storage (user info, afloat market place id, afloat collection id, afloat asset id, afloat offers, afloat transactions)
| @@ -161,6 +161,17 @@ pub enum CreateOfferArgs<T: Config> { | |||
| }, | |||
|
GPT summary of 35e5ba0:
PR summary so far:
|
tlacloc
added a commit
that referenced
this pull request
Sep 25, 2023
* - Updated the Fund Admin Records' list of dependencies in Cargo.toml,… (#10) * - Updated the Fund Admin Records' list of dependencies in Cargo.toml, bumping versions of 'frame support', 'frame system', 'frame benchmarking', 'sp runtime', 'pallet timestamp', 'sp core' and 'sp io' to be compatible with 'polkadot-v0.9.40' from 'polkadot-v0.9.38', aligning with the latest Substrate version. This ensures our pallets stay up-to-date with the latest turnkey infrastructure enabling efficient blockchain development. - Amended the weight ranges for three different calls - 'set_signer_account', 'add_record', and 'kill_storage' - within the Fund Admin Records pallet. We've changed the implementation to 'from_parts', explicitly setting the 'compute' part of the weight to 10,000 and 'io' part to 0. This provides a more specific weight range, optimizing on-chain resource use when these calls are processed. * DEVELOPMENT AND TROUBLESHOOTING - Updated the `pallet` macro for the Fund Admin Records pallet, specifying `STORAGE_VERSION` for better versioning control of the storage data. This ensures proper migration handling in future updates. - Commented out certain test function bodies in the Fund Admin Records pallet. This indicates an ongoing refactoring process and tests will be revisited to ensure they align with the new implementation specifics. - Updated the `pallet_rbac` configuration in the mock file of the Fund Admin pallet, adding `RemoveOrigin` set to `EnsureRoot<Self::AccountId>` to ensure that function calls, specific to the RBAC functionality, are executed by verified roots. - Carried out codebase clean-up in the Gated Marketplace pallet, removing unneeded imports and fixing an incorrect closing tag on the `Config` implementation block. - Updated the test suite for the Gated Marketplace pallet. Ensured that the `mint` function placing assets in the marketplace is correctly unwrapped using `assert_ok`. Commented out certain test cases, indicating a significant refactoring process which the tests will be revisited to align with. - Adjusted the properties order in the pallet-rbac dependency within the Mapped Assets pallet's Cargo.toml for consistency and readability. - Set up RBAC pallet in the test environment for the Mapped Assets pallet, implementing specific parameter types and configuring RBAC pallet for the test setup. - Updated the test suite for the RBAC pallet. Several test cases were commented out indicating an ongoing refactoring process which the tests will be revisited to align with. * update kill storage and bug fixes (#11) * 🐛 fix(afloat): modify `kill_storage` function to accept `args` parameter for more granular control over storage deletion ✨ feat(afloat): add `KillStorageArgs` enum to specify different types of storage to be deleted in `kill_storage` function * 🐛 fix(functions.rs): add authorization check in do_cancel_offer function to ensure only admin or offer creator can cancel the offer 🐛 fix(lib.rs): remove redundant authorization check in cancel_offer function * update kill storage (#13) * 🐛 fix(afloat): modify `kill_storage` function to accept `args` parameter for more granular control over storage deletion ✨ feat(afloat): add `KillStorageArgs` enum to specify different types of storage to be deleted in `kill_storage` function * 🐛 fix(functions.rs): add authorization check in do_cancel_offer function to ensure only admin or offer creator can cancel the offer 🐛 fix(lib.rs): remove redundant authorization check in cancel_offer function * Afloat update kill storage (#14) * 🐛 fix(afloat): modify `kill_storage` function to accept `args` parameter for more granular control over storage deletion ✨ feat(afloat): add `KillStorageArgs` enum to specify different types of storage to be deleted in `kill_storage` function * 🐛 fix(functions.rs): add authorization check in do_cancel_offer function to ensure only admin or offer creator can cancel the offer 🐛 fix(lib.rs): remove redundant authorization check in cancel_offer function * update pallets * 🔧 chore(rbac/functions.rs): remove unnecessary whitespace in comments for better readability 🔧 chore(rbac/functions.rs): remove unnecessary whitespace in comments for better readability --------- Co-authored-by: Didier Mis <didier.mis.may@gmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.