Afloat setup permissions #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tlacloc
commented
Sep 26, 2023
•
tlacloc
commented
- Update format for all pallets using fmt
- Refactor initial setup on afloat pallet to allow either initialize all pallets or just setup the roles (change needed for Chaos)
…prove code readability ✨ feat(types.rs): add InitialSetupArgs enum to handle initial setup arguments for asset creation and role assignment
…improve code cleanliness and readability ✨ feat(functions.rs): rename `do_setup_asset` function to `do_create_afloat_asset` for better naming consistency and clarity ✨ feat(lib.rs): refactor `InitialSetupArgs::All` match arm to call necessary setup functions in the correct order for initializing afloat pallet
…dd_account_to_afloat_frunique for better clarity and consistency 🐛 fix(lib.rs): rename add_to_afloat_collection function to do_add_account_to_afloat_frunique for better clarity and consistency
…`cargo fmt` before committing 🐛 fix(afloat): remove unnecessary commented out code in pallet module
… in Afloat pallet to explain its inputs and purpose 🔥 refactor(lib.rs): remove unnecessary empty line in Afloat pallet module
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -0,0 +1,13 @@ | |||
| #!/bin/bash | |||
| @@ -6,7 +6,7 @@ | |||
| "Permill" | |||
| @@ -1,894 +1,985 @@ | |||
| use super::*; | |||
| @@ -13,427 +13,391 @@ pub mod types; | |||
|
|
|||
| @@ -1,13 +1,13 @@ | |||
| use crate as pallet_afloat; | |||
| @@ -4,11 +4,11 @@ use frame_support::{assert_noop, assert_ok, traits::Currency, BoundedVec}; | |||
| use frame_system::RawOrigin; | |||
| @@ -1,6 +1,5 @@ | |||
| use super::*; | |||
| @@ -1,18 +1,19 @@ | |||
| use super::*; | |||
There was a problem hiding this comment.
GPT summary of 0a814a - a963f9:
- Removed unnecessary imports and added imports for lite-json and sp_runtime
- Added a new function
do_remove_proofto remove a proof of reserves - Added a new function
get_pending_vaultsto get vaults with pending descriptors - Added a new function
get_pending_proposalsto get proposals with pending PSBTs - Added a new function
get_finalizable_proposalsto get proposals that can be finalized - Added a new function
do_insert_descriptorsto insert vault descriptors - Added a new function
do_insert_proposalto insert a proposal - Added a new function
do_finalize_proposalto finalize a proposal - Added a new function
bdk_gen_finalized_proposalto generate a finalized proposal - Added a new function
parse_vault_descriptorsto parse vault descriptors - Added a new function
http_postto make HTTP POST requests - Added a new function
build_offchain_errto build an offchain error - Implemented BlockNumberProvider trait
| @@ -20,25 +20,23 @@ pub mod pallet { | |||
| //#[cfg(feature = "std")] | |||
| @@ -1,20 +1,22 @@ | |||
| use crate as pallet_bitcoin_vaults; | |||
There was a problem hiding this comment.
| @@ -1,22 +1,21 @@ | |||
| use super::*; | |||
| @@ -1,6 +1,5 @@ | |||
| use super::*; | |||
| @@ -66,7 +66,7 @@ pub mod pallet { | |||
|
|
|||
| @@ -533,7 +533,6 @@ fn update_shared_document_metadata_works() { | |||
| )); | |||
There was a problem hiding this comment.
GPT summary of 8ed742 - 6e4c07:
- Updated the
update_shared_document_metadata_works()test to remove a line - Updated the
remove_group_member_works_for_admin_removing_member_he_added()test to add a line and update an existing line - Added a new test
remove_group_member_should_fail_for_trying_to_remove_owner() - Updated the
remove_group_member_should_fail_for_role_member_as_authorizer()test - Updated the
remove_group_member_should_fail_for_admin_removing_member_he_did_not_add()test to remove a line
| @@ -118,7 +118,7 @@ impl<T: Config> GroupMember<T> { | |||
|
|
|||
| @@ -16,494 +16,512 @@ pub mod types; | |||
|
|
|||
| @@ -4,24 +4,24 @@ use frame_system::{EnsureRoot, EnsureSigned}; | |||
| use pallet_balances; | |||
There was a problem hiding this comment.
| @@ -14,208 +14,211 @@ pub struct ExtBuilder; | |||
| // } | |||
| @@ -25,239 +25,245 @@ pub type Percentage = u16; | |||
| #[scale_info(skip_type_params(T))] | |||
|
GPT summary of ec717fc: Error: couldn't generate summary |
|
GPT summary of 04d6062: Error: couldn't generate summary |
|
GPT summary of 48a7d51: Error: couldn't generate summary |
|
GPT summary of 47e772c: Error: couldn't generate summary |
|
GPT summary of c32c0dc: Error: couldn't generate summary |
|
GPT summary of 2dbc165:
|
|
GPT summary of 1f7fd19: Error: couldn't generate summary |
|
GPT summary of 83b7b5a: Error: couldn't generate summary |
|
GPT summary of 1670518: Error: couldn't generate summary |
|
GPT summary of dee30ef:
|
|
GPT summary of 960f859:
|
|
GPT summary of a716dd9:
|
|
GPT summary of 9e88a8d:
|
|
GPT summary of 9b9f146:
PR summary so far:
|
🔧 chore(check.yml): add step to check Rust build using cargo check --release
| @@ -36,6 +36,12 @@ jobs: | |||
| rustup update nightly | |||
There was a problem hiding this comment.
| @@ -17,4 +17,4 @@ benchmarks! { | |||
| } | |||
| @@ -1,64 +1,55 @@ | |||
| use super::*; | |||
There was a problem hiding this comment.
GPT summary of 852ac5 - 716176:
- Added a function
do_add_recordto add records to the storage - Validated the inputs of the function to check if the project ID and hashed info are not empty
- Generated a unique record ID based on the inputs
- Inserted the record into the storage
- Emitted an event to notify that a record was added
| @@ -16,10 +16,9 @@ mod types; | |||
|
|
|||
There was a problem hiding this comment.
GPT summary of c6aced - 7a20e4:
- Changed
use frame_support::pallet_prelude::*;touse frame_support::{pallet_prelude::*, traits::Time}; - Removed
use frame_support::traits::Time; - Added
MaxRecordsAtTimeconstant - Added
SignerAccountstorage - Added
Recordsstorage - Added
RecordAddedevent - Added
MaxRegistrationsAtATimeReachederror - Added
set_signer_accountextrinsic - Added
add_recordextrinsic - Added
kill_storageextrinsic
| @@ -68,10 +68,7 @@ impl pallet_fund_admin_records::Config for Test { | |||
| type MaxRecordsAtTime = MaxRecordsAtTime; | |||
| use crate::{mock::*, types::*, Records, Error}; | ||
| use frame_support::{assert_ok, assert_noop, bounded_vec}; | ||
|
|
||
| use crate::{mock::*, types::*, Error, Records}; |
| @@ -5,14 +5,10 @@ pub type HashedInfo = BoundedVec<u8, ConstU32<400>>; | |||
| pub type Id = [u8; 32]; | |||
| @@ -4,241 +4,243 @@ use super::*; | |||
| const LOG_TARGET: &str = "\nFund Admin pallet migration "; | |||
|
GPT summary of 62494a9:
PR summary so far:
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.