Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

update roles assignment for afloat #17

Merged
merged 2 commits into from
Sep 27, 2023
Merged

update roles assignment for afloat #17

merged 2 commits into from
Sep 27, 2023

Conversation

tlacloc
Copy link
Contributor

@tlacloc tlacloc commented Sep 27, 2023

No description provided.

@tlacloc
🔧 chore(functions.rs): remove commented out code for creating asset i…
37faeb1 
…n do_create_marketplace function

✨ feat(functions.rs): add documentation for do_create_marketplace function to explain its purpose and behavior
@tlacloc
🔧 chore(lib.rs): remove unused imports to improve code cleanliness an…
1000da4 
…d reduce clutter

✨ feat(lib.rs): add new events to track user creation, editing, deletion, sell and buy order creation, order taking, balance updates, admin addition, and user role assignment
🐛 fix(lib.rs): fix typo in event comment
🚀 feat(lib.rs): add new extrinsic `assign_user_to_role` to allow assigning a user to a role
github-actions[bot]
github-actions bot reviewed Sep 27, 2023
View reviewed changes
pallets/afloat/src/lib.rs
@@ -15,13 +15,11 @@ pub mod types;
pub mod pallet {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GPT summary of 93b888 - 6a74f5:

  • Added NewUser, UserEdited, UserDeleted, SellOrderCreated, BuyOrderCreated, SellOrderTaken, BuyOrderTaken, AfloatBalanceSet, AdminAdded events
  • Added assign_user_to_role call which assigns a user to a role and emits UserAssignedToRoleAdded event

github-actions[bot]
github-actions bot reviewed Sep 27, 2023
View reviewed changes
pallets/gated-marketplace/src/functions.rs
@@ -45,6 +45,9 @@ impl<T: Config> Pallet<T> {
Ok(())
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GPT summary of 977293 - f6924d:

  • Added a function do_create_marketplace to create a new marketplace.
  • The owner and admin are added to the marketplace as authorities.
  • Ensured the generated id is unique.
  • Inserted on marketplaces and marketplaces by auth.

@github-actions
Copy link

GPT summary of 37faeb1:

  • Added a do_create_marketplace function that creates a new marketplace, adds the owner and admin as authorities, and uses an existing asset as the currency functions.rs
  • Removed the creation of a new asset functions.rs

@github-actions
Copy link

GPT summary of 1000da4:

  • Added events for new user, user edit, user delete, sell order created, buy order created, sell order taken, buy order taken, balance set, admin added, and user assigned to role lib.rs
  • Added a call to assign a user to a role lib.rs

PR summary so far:

  • Created a function to create a new marketplace, adding the owner and admin as authorities
  • Added events for new user, user edit, user delete, sell order created, buy order created, sell order taken, buy order taken, balance set, admin added, and user assigned to role
  • Added a call to assign a user to a role

@tlacloc tlacloc merged commit 7ec0bdf into main Sep 27, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tlacloc