Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Acceptance test CICD #120

Merged
merged 4 commits into from
May 31, 2022
Merged

Acceptance test CICD #120

merged 4 commits into from
May 31, 2022

Conversation

Ivo-Yankov
Copy link
Collaborator

@Ivo-Yankov Ivo-Yankov commented May 31, 2022

Description:
Add support for Acceptance tests to run in CI/CD flow

  • Add a localAcceptance.env that provides configurations for local-node runs
  • Update package to pull latest npm version of hedera-local-node

Related issue(s):

Addresses #17

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@Ivo-Yankov Ivo-Yankov self-assigned this May 31, 2022
@Ivo-Yankov Ivo-Yankov marked this pull request as ready for review May 31, 2022 17:07
@Ivo-Yankov Ivo-Yankov linked an issue May 31, 2022 that may be closed by this pull request
@Ivo-Yankov Ivo-Yankov requested a review from Nana-EC May 31, 2022 17:33
Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.
One nit suggestion and a question

@Nana-EC Nana-EC added enhancement New feature or request P2 process Build, test and deployment-process related tasks labels May 31, 2022
@Nana-EC Nana-EC added this to the 0.1.0 milestone May 31, 2022
@Nana-EC
Copy link
Collaborator

Nana-EC commented May 31, 2022

Updated PR comment so that merging this doesn't close #17 and will update my PR to automatically close that noting this PR

@Nana-EC Nana-EC mentioned this pull request May 31, 2022
2 tasks
Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nana-EC Nana-EC force-pushed the 17-acceptance-cicd branch from d2e58d1 to 5319aa3 Compare May 31, 2022 21:46
@Nana-EC Nana-EC force-pushed the 76-acceptance-tests branch from d01e132 to c8a0572 Compare May 31, 2022 21:51
Nana-EC and others added 4 commits May 31, 2022 16:52
Signed-off-by: Nana-EC <nana@swirldslabs.com>
Signed-off-by: Nana-EC <nana@swirldslabs.com>
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
@Nana-EC Nana-EC force-pushed the 17-acceptance-cicd branch from 5319aa3 to ec48412 Compare May 31, 2022 21:53
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Nana-EC Nana-EC merged commit 7ac4ff8 into 76-acceptance-tests May 31, 2022
@Nana-EC Nana-EC deleted the 17-acceptance-cicd branch May 31, 2022 21:55
Nana-EC added a commit that referenced this pull request May 31, 2022
* More test cases and ethereum transaction start

Add support for Acceptance tests to run in CI/CD flow

- Add a `localAcceptance.env` that provides configurations for local-node runs
- Update package to pull latest npm version of `hedera-local-node`

Co-authored-by: Nana-EC <nana@swirldslabs.com>
Nana-EC added a commit that referenced this pull request May 31, 2022
* More test cases and ethereum transaction start

Add support for Acceptance tests to run in CI/CD flow

- Add a `localAcceptance.env` that provides configurations for local-node runs
- Update package to pull latest npm version of `hedera-local-node`

Co-authored-by: Nana-EC <nana@swirldslabs.com>
Signed-off-by: Nana-EC <nana@swirldslabs.com>
Nana-EC added a commit that referenced this pull request Jun 2, 2022
* Acceptance tests setup

Add acceptance tests to help verify relay operation in full Hedera Hashgraph environments, both local and deployed

- Add an `acceptance.spec.ts` file to hold test logic
  - Load `hedera-local-node` before all tests
  - Use sdk-js to submit setup transactions - ECDSA based accounts, contracts, tokens
  - Add a test case for each server endpoint and verify response 
- Update README with Testing section with clear instructions how to run acceptance tests
- Update `sdk-js` version used to support `EthereumTransactions`
- Add github action to run on PR submission - Done by #120 
- Add reference smart contract (Parent.sol) to enable calls

Signed-off-by: Nana-EC <nana@swirldslabs.com>

Co-authored-by: Ivo Yankov <ivo@devlabs.bg>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request P2 process Build, test and deployment-process related tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI/CD pipeline to run e2e tests
2 participants