Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Improve server logging and metrics #132

Merged
merged 3 commits into from
Jun 2, 2022
Merged

Conversation

Nana-EC
Copy link
Collaborator

@Nana-EC Nana-EC commented Jun 1, 2022

Signed-off-by: Nana-EC nana@swirldslabs.com

Description:
Improve server logging and metrics and minor issues noted from logging

  • Add latency to server metrics
  • Simplify metrics by removing single label options
  • Move result conversion logic into eth and out of server
  • Reduce verbosity of mirrorNode class
  • Add Mirror prefix to mirror node REST API calls
  • Add setTransactionId to CostQuery to workaround Query.PaymentTransactionId was not set duration execution error for CostQuery

Related issue(s):

Fixes #131

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@Nana-EC Nana-EC added enhancement New feature or request P3 labels Jun 1, 2022
@Nana-EC Nana-EC added this to the 0.1.0 milestone Jun 1, 2022
@Nana-EC Nana-EC self-assigned this Jun 1, 2022
Signed-off-by: Nana-EC <nana@swirldslabs.com>
@Nana-EC Nana-EC force-pushed the 131-improve-logging-metrics branch from 0f5dd6f to 16a8b59 Compare June 2, 2022 13:48
Nana-EC added 2 commits June 2, 2022 12:54
Signed-off-by: Nana-EC <nana@swirldslabs.com>
Signed-off-by: Nana-EC <nana@swirldslabs.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@possible-panther possible-panther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Nana-EC Nana-EC merged commit eed4c1e into main Jun 2, 2022
@Nana-EC Nana-EC deleted the 131-improve-logging-metrics branch June 2, 2022 20:06
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request P3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve server logging and metrics
2 participants