Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

049 hbar transfer demo docs #168

Merged
merged 9 commits into from
Jun 8, 2022
Merged

Conversation

possible-panther
Copy link
Contributor

Description:
Adds documentation of steps for creation of aliased accounts and how to transfer hbar between them.

Related issue(s):

Fixes #49

Signed-off-by: Mitchell Martin <mitch@swirldslabs.com>
@possible-panther possible-panther self-assigned this Jun 7, 2022
Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.
Some suggestions and a few requests for screenshots.
Notable from the Hedera -> Ehh side there may be people for who this is their first exposure to a non Hedera wallet so the screenshots help

@codecov-commenter
Copy link

codecov-commenter commented Jun 8, 2022

Codecov Report

Merging #168 (108aebd) into main (ae99b1b) will not change coverage.
The diff coverage is n/a.

❗ Current head 108aebd differs from pull request most recent head 0992ba5. Consider uploading reports for the commit 0992ba5 to get more accurate results

@@           Coverage Diff           @@
##             main     #168   +/-   ##
=======================================
  Coverage   67.41%   67.41%           
=======================================
  Files           6        6           
  Lines         534      534           
  Branches       71       71           
=======================================
  Hits          360      360           
  Misses        154      154           
  Partials       20       20           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae99b1b...0992ba5. Read the comment docs.

@Nana-EC Nana-EC added documentation Improvements or additions to documentation enhancement New feature or request P2 labels Jun 8, 2022
@Nana-EC Nana-EC added this to the 0.2.0 milestone Jun 8, 2022
@possible-panther possible-panther force-pushed the 049-hbar-transfer-demo-docs branch 2 times, most recently from 5d40658 to c5f0142 Compare June 8, 2022 15:11
Mitchell Martin added 5 commits June 8, 2022 10:19
Signed-off-by: Mitchell Martin <mitch@swirldslabs.com>
Signed-off-by: Mitchell Martin <mitch@swirldslabs.com>
Signed-off-by: Mitchell Martin <mitch@swirldslabs.com>
Signed-off-by: Mitchell Martin <mitch@swirldslabs.com>
Mitchell Martin and others added 3 commits June 8, 2022 11:18
Signed-off-by: Mitchell Martin <mitch@swirldslabs.com>
Signed-off-by: Mitchell Martin <mitch@swirldslabs.com>

Co-authored-by: Nana Essilfie-Conduah <56320167+Nana-EC@users.noreply.github.com>
Signed-off-by: Mitchell Martin <mitch@swirldslabs.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@possible-panther possible-panther merged commit cadd676 into main Jun 8, 2022
@possible-panther possible-panther deleted the 049-hbar-transfer-demo-docs branch June 8, 2022 16:28
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request P2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document HBAR transfer Relay interaction steps to a markdown file
3 participants