Cache eth_feeHistory inner value #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nana-EC <nana@swirldslabs.com>
Signed-off-by: Nana-EC <nana@swirldslabs.com>
|
Kudos, SonarCloud Quality Gate passed!
|
shemnon
approved these changes
Jun 9, 2022
Daniel-K-Ivanov
approved these changes
Jun 9, 2022
Nana-EC
added a commit
that referenced
this pull request
Jun 9, 2022
* Cache eth_feeHistory inner value Signed-off-by: Nana-EC <nana@swirldslabs.com> * Add eth.spec test Signed-off-by: Nana-EC <nana@swirldslabs.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nana-EC nana@swirldslabs.com
Description:
Given the fees don't change much we should cache the result for some time
Related issue(s):
Fixes #174
Notes for reviewer:
Tested local instance against previewnet
Checklist