Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Improve release git action flow #205

Merged
merged 1 commit into from
Jun 13, 2022
Merged

Improve release git action flow #205

merged 1 commit into from
Jun 13, 2022

Conversation

Nana-EC
Copy link
Collaborator

@Nana-EC Nana-EC commented Jun 13, 2022

Signed-off-by: Nana-EC nana@swirldslabs.com

Description:
Improve release git action

  • Split docker and npm artifact out into separate jobs
  • Fix npm package name in upload step

Related issue(s):

Fixes #204

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@Nana-EC
Improve release git action flow
767f4ac 
Signed-off-by: Nana-EC <nana@swirldslabs.com>
@Nana-EC Nana-EC added enhancement New feature or request P2 process Build, test and deployment-process related tasks labels Jun 13, 2022
@Nana-EC Nana-EC added this to the 0.2.0 milestone Jun 13, 2022
@Nana-EC Nana-EC self-assigned this Jun 13, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

possible-panther
possible-panther approved these changes Jun 13, 2022
View reviewed changes
Copy link
Contributor

@possible-panther possible-panther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to go

@Nana-EC Nana-EC merged commit c7582d1 into main Jun 13, 2022
@Nana-EC Nana-EC deleted the 204-improve-release-action branch June 13, 2022 23:47
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@possible-panther possible-panther possible-panther approved these changes

@shemnon shemnon Awaiting requested review from shemnon

@Daniel-K-Ivanov Daniel-K-Ivanov Awaiting requested review from Daniel-K-Ivanov

Assignees

@Nana-EC Nana-EC

Labels
enhancement New feature or request P2 process Build, test and deployment-process related tasks
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.

Improve release git action logic
2 participants
@Nana-EC @possible-panther