Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add transactionhash to receipt logs #235

Merged
merged 1 commit into from
Jun 17, 2022
Merged

Conversation

Nana-EC
Copy link
Collaborator

@Nana-EC Nana-EC commented Jun 17, 2022

Signed-off-by: Nana-EC nana@swirldslabs.com

Description:
go-eth client seems to be stricter than other clients and requires the transaction hash in logs

  • Add transactionHash in logs
  • Updated eth.spec.ts

Related issue(s):

Fixes #226

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Nana-EC <nana@swirldslabs.com>
@Nana-EC Nana-EC requested a review from shemnon June 17, 2022 20:07
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Nana-EC Nana-EC self-assigned this Jun 17, 2022
@Nana-EC Nana-EC added enhancement New feature or request P2 dev tools Features enabling dev tool integration labels Jun 17, 2022
@Nana-EC Nana-EC added this to the 0.2.0 milestone Jun 17, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #235 (d46a2e2) into main (75625e1) will increase coverage by 0.05%.
The diff coverage is 57.14%.

❗ Current head d46a2e2 differs from pull request most recent head 30d12f6. Consider uploading reports for the commit 30d12f6 to get more accurate results

@@            Coverage Diff             @@
##             main     #235      +/-   ##
==========================================
+ Coverage   66.08%   66.13%   +0.05%     
==========================================
  Files           7        7              
  Lines         625      626       +1     
  Branches       90       92       +2     
==========================================
+ Hits          413      414       +1     
  Misses        184      184              
  Partials       28       28              
Impacted Files Coverage Δ
packages/relay/src/lib/eth.ts 55.72% <57.14%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75625e1...30d12f6. Read the comment docs.

@Nana-EC Nana-EC merged commit 8479372 into main Jun 17, 2022
@Nana-EC Nana-EC deleted the 226-add-log-transactionhash branch June 17, 2022 21:38
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
dev tools Features enabling dev tool integration enhancement New feature or request P2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eth_getTransactionReceipt go-ethereum compatibility
3 participants