Fix getLogs mapping to retrieve unique execution logs (2.0) #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix getLogs mapping to retrieve uniqu execution logs `eth-getLogs` logic was grouping transactions via `contractId-timestamp`. This resulted in logs getting missed since the contractId of logs from called contracts differ from the caller - Update `eth_getLogs` call to group log results via timestamp to determine unique executions - Update integration tests - Updated acceptance test image versions Signed-off-by: Nana-EC <nana@swirldslabs.com>
Nana-EC
added
bug
|
Kudos, SonarCloud Quality Gate passed!
|
shemnon
changed the title
shemnon
approved these changes
Jun 27, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nana-EC nana@swirldslabs.com
Description:
Cherry pick #270
eth-getLogslogic was grouping transactions viacontractId-timestamp.This resulted in logs getting missed since the contractId of logs from called contracts differ from the caller
eth_getLogscall to group log results via timestamp to determine unique executionsRelated issue(s):
Addresses #268
Notes for reviewer:
Checklist