Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

HTS acceptance tests #298

Merged
merged 7 commits into from
Jul 13, 2022
Merged

HTS acceptance tests #298

merged 7 commits into from
Jul 13, 2022

Conversation

Ivo-Yankov
Copy link
Collaborator

@Ivo-Yankov Ivo-Yankov commented Jul 6, 2022 •
edited
Loading

Description:

Related issue(s):

Fixes #280

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Ivo-Yankov added 2 commits July 6, 2022 12:41
@Ivo-Yankov
refactor: allow running erc20 tests against several contracts
3592c47 
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
@Ivo-Yankov
test: run erc20 tests against hts
999d2ce 
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
@Kalina-Todorova Kalina-Todorova linked an issue Jul 7, 2022 that may be closed by this pull request
Extend/change the erc20.spec.ts to tokens.spec.ts to include HTS tokens #280
Closed
Ivo-Yankov added 4 commits July 8, 2022 10:33
@Ivo-Yankov
wip: hts tests
f40c456 
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
@Ivo-Yankov
test: disable allowance tests for hts
2ca2ab3 
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
@Ivo-Yankov
Merge branch 'main' into 280-hts-acceptance-tests
238ea6f 
# Conflicts:
#	packages/server/tests/acceptance/erc20.spec.ts
#	packages/server/tests/clients/servicesClient.ts
@Ivo-Yankov
chore: resolve conflicts
0c06cdc 
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
@Ivo-Yankov Ivo-Yankov marked this pull request as ready for review July 11, 2022 09:04
@Ivo-Yankov Ivo-Yankov changed the title 280 hts acceptance tests HTS acceptance tests Jul 11, 2022
@Ivo-Yankov Ivo-Yankov self-assigned this Jul 11, 2022
@Ivo-Yankov Ivo-Yankov added enhancement New feature or request limechain labels Jul 11, 2022
@Ivo-Yankov Ivo-Yankov added this to the 0.4.0 milestone Jul 11, 2022
Nana-EC
Nana-EC requested changes Jul 11, 2022
View reviewed changes
Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, treasury account needs to be changed

@Ivo-Yankov
feat: specify admin account when creating hts
28644ff 
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Nana-EC
Nana-EC approved these changes Jul 12, 2022
View reviewed changes
Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@Nana-EC Nana-EC merged commit 73d8244 into main Jul 13, 2022
@Nana-EC Nana-EC deleted the 280-hts-acceptance-tests branch July 13, 2022 01:45
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Nana-EC Nana-EC Nana-EC approved these changes

Assignees

@Ivo-Yankov Ivo-Yankov

Labels
enhancement New feature or request limechain
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.

Extend/change the erc20.spec.ts to tokens.spec.ts to include HTS tokens
2 participants
@Ivo-Yankov @Nana-EC