Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix schema mismatch for nums in eth_getTransactionReceipt response (0.3) #324

Closed
wants to merge 1 commit into from
Closed

Fix schema mismatch for nums in eth_getTransactionReceipt response (0.3) #324

wants to merge 1 commit into from

Conversation

Nana-EC
Copy link
Collaborator

@Nana-EC Nana-EC commented Jul 11, 2022

  • Fix schema mismatch for nums in eth_getTransactionReceipt response

Signed-off-by: Nana-EC nana@swirldslabs.com

Description:
Cherry-pck #315

Related issue(s):

Fixes #302

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@Nana-EC
Fix schema mismatch for nums in eth_getTransactionReceipt response (#315
c25bb6c 
)

* Fix schema mismatch for nums in eth_getTransactionReceipt response

Signed-off-by: Nana-EC <nana@swirldslabs.com>
@Nana-EC Nana-EC requested a review from shemnon July 11, 2022 18:33
@Nana-EC Nana-EC self-assigned this Jul 11, 2022
@Nana-EC Nana-EC added bug Something isn't working P2 labels Jul 11, 2022
@Nana-EC Nana-EC added this to the 0.3.0 milestone Jul 11, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Nana-EC Nana-EC requested a review from Ivo-Yankov July 11, 2022 18:53
@shemnon
Copy link
Contributor

shemnon commented Jul 11, 2022

This is the wrong fix. The schema (model.ts) should be updated.

The definition of uint in the official execution APIs is a hex string - https://github.com/ethereum/execution-apis/blob/main/src/schemas/base-types.yaml#L34

The fields types are all uint - https://github.com/ethereum/execution-apis/blob/main/src/schemas/receipt.yaml

@Nana-EC
Copy link
Collaborator Author

Nana-EC commented Jul 12, 2022

Closing as this isn' the desired fix.
Main branch will see some updates and those will make their way to production in 0.4

@Nana-EC Nana-EC closed this Jul 12, 2022
@Nana-EC Nana-EC removed this from the 0.3.0 milestone Jul 12, 2022
@shemnon
Copy link
Contributor

shemnon commented Jul 12, 2022

see #332

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@shemnon shemnon Awaiting requested review from shemnon

@Ivo-Yankov Ivo-Yankov Awaiting requested review from Ivo-Yankov

Assignees

@Nana-EC Nana-EC

Labels
bug Something isn't working P2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nana-EC @shemnon