Cannot estimate gasPrice on previewnet #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anton Rusev <anton.rusev.code@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #345 +/- ##
=======================================
Coverage 62.29% 62.29%
=======================================
Files 9 9
Lines 870 870
Branches 142 142
=======================================
Hits 542 542
Misses 290 290
Partials 38 38 Continue to review full report at Codecov.
|
Signed-off-by: nikolay <n.atanasow94@gmail.com>
|
Kudos, SonarCloud Quality Gate passed!
|
Nana-EC
approved these changes
Jul 19, 2022
shemnon
approved these changes
Jul 19, 2022
Nana-EC
added
enhancement
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anton Rusev anton.rusev.code@gmail.com
Description:
2.17.0Related issue(s):
Fixes #344
Notes for reviewer:
Fees file on previewnet contains a new fee type(
hederaFunctionality=86) which does not exists in the older sdk versions and cannot be parsed by the sdkadded in v. 2.17.0:
Checklist