Complete eth_getStorageAt implementation #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #361 +/- ##
==========================================
- Coverage 62.35% 62.21% -0.15%
==========================================
Files 9 9
Lines 866 868 +2
Branches 142 142
==========================================
Hits 540 540
- Misses 288 290 +2
Partials 38 38
Continue to review full report at Codecov.
|
Signed-off-by: Luke Lee <luke.lee@swirldslabs.com>
lukelee-sl
force-pushed
the
355-complete-getStorageAt
branch
from
55db696 to
20c1f9d
Compare
Signed-off-by: Luke Lee <luke.lee@swirldslabs.com>
Nana-EC
added
enhancement
Nana-EC
previously approved these changes
Jul 20, 2022
lukelee-sl
force-pushed
the
355-complete-getStorageAt
branch
from
e2d05bc to
de7efdd
Compare
Signed-off-by: lukelee-sl <luke.lee@swirldslabs.com>
|
Kudos, SonarCloud Quality Gate passed!
|
|
@Nana-EC one more approval please. For whatever reason, the email used when signing my last 2 commits was incorrect. I've addressed the issue and resubmitted. |
Nana-EC
approved these changes
Jul 21, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Implement the eth_getStorageAt call as an unsupported method.
Related issue(s):
Fixes #355
Notes for reviewer:
Checklist