Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

remove mirrorNode.ts and dependencies #374

Merged
merged 2 commits into from
Jul 25, 2022
Merged

Conversation

lukelee-sl
Copy link
Member

Signed-off-by: lukelee-sl luke.lee@swirldslabs.com

Description:
This PR removes the mock MirrorNode class and relevant dependencies

Related issue(s):

Fixes #253

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: lukelee-sl <luke.lee@swirldslabs.com>
Signed-off-by: lukelee-sl <luke.lee@swirldslabs.com>
@Nana-EC Nana-EC requested review from shemnon and Nana-EC July 22, 2022 20:50
@Nana-EC Nana-EC added enhancement New feature or request P3 labels Jul 22, 2022
@Nana-EC Nana-EC added this to the 0.5.0 milestone Jul 22, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, just waiting on acceptance test pass

@lukelee-sl lukelee-sl requested a review from Nana-EC July 24, 2022 05:26
Copy link
Collaborator

@natanasow natanasow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@lukelee-sl lukelee-sl merged commit 9288e0c into main Jul 25, 2022
@lukelee-sl lukelee-sl deleted the 253-remove-mock-mirrorNode branch July 25, 2022 14:50
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request P3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove use and references to mock MirrorNode
3 participants