Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

ci: Remove unnecessary check in node-flow-deploy-release-artifact #15768

Conversation

rbarker-dev
Copy link
Contributor

Description:

Removes the checkout code and verify HAPI version steps from the Prepare Release [Tag] job

Related Issue(s):

Fixes: #15767

*Description*:

Removes the `checkout code` and `verify HAPI version` steps from the
Prepare Release [Tag] job

*Related Issue(s)*:

Fixes: #15767

Signed-off-by: Roger Barker <roger.barker@swirldslabs.com>
@rbarker-dev rbarker-dev added the github_actions Pull requests that update GitHub Actions code label Oct 2, 2024
@rbarker-dev rbarker-dev added this to the v0.55 milestone Oct 2, 2024
@rbarker-dev rbarker-dev self-assigned this Oct 2, 2024
@rbarker-dev rbarker-dev marked this pull request as ready for review October 2, 2024 18:30
@rbarker-dev rbarker-dev requested review from a team as code owners October 2, 2024 18:30
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (cb62efb) 109360 67533 61.75%
Head commit (74ee9e4) 109360 (+0) 67533 (+0) 61.75% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#15768) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.21%. Comparing base (cb62efb) to head (74ee9e4).
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             develop   #15768   +/-   ##
==========================================
  Coverage      58.21%   58.21%           
  Complexity     21620    21620           
==========================================
  Files           2784     2784           
  Lines         109543   109543           
  Branches       11212    11212           
==========================================
  Hits           63768    63768           
  Misses         41900    41900           
  Partials        3875     3875           

Impacted file tree graph

@rbarker-dev rbarker-dev merged commit cf475f5 into develop Oct 2, 2024
73 of 74 checks passed
@rbarker-dev rbarker-dev deleted the 15767-remove-inline-check-for-hapi-version-mismatch-in-node-flow-deploy-release-artifact branch October 2, 2024 19:12
rbarker-dev added a commit that referenced this pull request Oct 2, 2024
…5768)

Signed-off-by: Roger Barker <roger.barker@swirldslabs.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove inline check for HAPI version mismatch in node-flow-deploy-release-artifact
2 participants