-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: log roster history at start of platform #17182
feat: log roster history at start of platform #17182
Conversation
Signed-off-by: Edward Wertz <edward@swirldslabs.com>
Signed-off-by: Edward Wertz <edward@swirldslabs.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17182 +/- ##
============================================
+ Coverage 67.23% 67.25% +0.01%
- Complexity 21988 21996 +8
============================================
Files 2583 2583
Lines 96320 96333 +13
Branches 10058 10060 +2
============================================
+ Hits 64764 64784 +20
+ Misses 27847 27842 -5
+ Partials 3709 3707 -2
|
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/roster/RosterHistory.java
Outdated
Show resolved
Hide resolved
fb9093b
Signed-off-by: Edward Wertz <edward@swirldslabs.com>
Description:
Logs the roster history at the start of the platform.
If the current roster is used as the previous roster, text is written to indicate this instead of repeating the same data.
The log message has the string encoding of each node's public certificates. To get rid of this, we would need to create more utility functions for pretty printing the roster into a JSON format without the certificates.
NOTE: The
ipAddressV4
entries are unreadable because the data is stored as 4 bytes instead of a string of the ip address.Sample Output From A Local Run:
Related issue(s):
Fixes #15476