Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

refactor: enhance migration testing tool #17246

Merged
merged 15 commits into from
Jan 14, 2025

Conversation

mustafauzunn
Copy link
Collaborator

Description:

Enhance the migration testing tool to work with new transactions of bytes.

Related issue(s):

Fixes #16842

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
@mustafauzunn mustafauzunn added the Platform Tickets pertaining to the platform label Jan 7, 2025
@mustafauzunn mustafauzunn added this to the v0.59 milestone Jan 7, 2025
@mustafauzunn mustafauzunn self-assigned this Jan 7, 2025
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 73.91304% with 6 lines in your changes missing coverage. Please review.

Project coverage is 67.62%. Comparing base (6dae710) to head (b2e99e5).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...rlds/demo/migration/MigrationTestingToolState.java 72.22% 3 Missing and 2 partials ⚠️
...irlds/demo/migration/MigrationTestingToolMain.java 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #17246      +/-   ##
============================================
+ Coverage     67.60%   67.62%   +0.02%     
- Complexity    22147    22159      +12     
============================================
  Files          2588     2588              
  Lines         96654    96676      +22     
  Branches      10099    10101       +2     
============================================
+ Hits          65343    65378      +35     
+ Misses        27571    27556      -15     
- Partials       3740     3742       +2     
Files with missing lines Coverage Δ
...m/swirlds/demo/migration/TransactionGenerator.java 76.47% <100.00%> (+1.47%) ⬆️
...a/com/swirlds/demo/migration/TransactionUtils.java 57.14% <100.00%> (+17.14%) ⬆️
...irlds/demo/migration/MigrationTestingToolMain.java 0.00% <0.00%> (ø)
...rlds/demo/migration/MigrationTestingToolState.java 32.98% <72.22%> (+32.98%) ⬆️

... and 2 files with indirect coverage changes

Impacted file tree graph

Copy link

codacy-production bot commented Jan 7, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.02% (target: -1.00%) 82.61%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (6dae710) 96437 68931 71.48%
Head commit (b2e99e5) 96459 (+22) 68968 (+37) 71.50% (+0.02%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17246) 23 19 82.61%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
@mustafauzunn mustafauzunn marked this pull request as ready for review January 9, 2025 12:28
@mustafauzunn mustafauzunn requested review from a team as code owners January 9, 2025 12:28
Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
andrewb1269hg
andrewb1269hg previously approved these changes Jan 9, 2025
Copy link
Contributor

@andrewb1269hg andrewb1269hg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review and approve file platform-sdk/platform-apps/tests/MigrationTestingTool/build.gradle.kts

…2-enhance-migration-testing-tool

# Conflicts:
#	platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/system/SwirldMain.java
Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
Copy link
Contributor

@andrewb1269hg andrewb1269hg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reapprove platform-sdk/platform-apps/tests/MigrationTestingTool/build.gradle.kts

@mustafauzunn mustafauzunn merged commit 5322bdc into main Jan 14, 2025
45 checks passed
@mustafauzunn mustafauzunn deleted the 16842-enhance-migration-testing-tool branch January 14, 2025 11:35
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Platform Tickets pertaining to the platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adapt MigrationTestingTool to work with new proto types and add README
5 participants