Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: restore ServicesMainTest.java #17262

Open
wants to merge 44 commits into
base: main
Choose a base branch
from

Conversation

edward-swirldslabs
Copy link
Contributor

@edward-swirldslabs edward-swirldslabs commented Jan 8, 2025

Fixes #17261

This PR restores the ServicesMainTest.java file with updated unit tests reflecting the new exit conditions for checking node ids provided by commandline or environment variable.

edward-swirldslabs and others added 30 commits March 13, 2024 14:51
Signed-off-by: Edward Wertz <edward@swirldslabs.com>
Signed-off-by: Edward Wertz <edward@swirldslabs.com>
Signed-off-by: Edward Wertz <edward@swirldslabs.com>
…-network

# Conflicts:
#	hedera-node/hedera-mono-service/src/main/java/com/hedera/node/app/service/mono/state/StateModule.java
#	hedera-node/hedera-mono-service/src/test/java/com/hedera/node/app/service/mono/ServicesAppTest.java
#	hedera-node/hedera-mono-service/src/test/java/com/hedera/node/app/service/mono/ServicesStateTest.java
#	platform-sdk/platform-apps/demos/CryptocurrencyDemo/src/main/java/com/swirlds/demo/crypto/CryptocurrencyDemoMain.java
#	platform-sdk/platform-apps/demos/HelloSwirldDemo/src/main/java/com/swirlds/demo/hello/HelloSwirldDemoMain.java
#	platform-sdk/platform-apps/demos/StatsDemo/src/main/java/com/swirlds/demo/stats/StatsDemoMain.java
#	platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/PlatformBuilder.java
#	platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/crypto/CryptoStatic.java
#	platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/crypto/EnhancedKeyStoreLoader.java
#	platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/gui/SwirldsGui.java
#	platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/network/connectivity/OutboundConnectionCreator.java
#	platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/state/address/AddressBookNetworkUtils.java
#	platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/util/BootstrapUtils.java
#	platform-sdk/swirlds-platform-core/src/test/java/com/swirlds/platform/crypto/CryptoArgsProvider.java
#	platform-sdk/swirlds-platform-core/src/test/java/com/swirlds/platform/util/AddressBookNetworkUtilsTests.java
Signed-off-by: Edward Wertz <edward@swirldslabs.com>
Signed-off-by: Edward Wertz <edward@swirldslabs.com>
Signed-off-by: Edward Wertz <edward@swirldslabs.com>
Signed-off-by: Edward Wertz <edward@swirldslabs.com>
Signed-off-by: Edward Wertz <edward@swirldslabs.com>
…-network

# Conflicts:
#	hedera-node/hedera-app/src/main/java/com/hedera/node/app/ServicesMain.java
Signed-off-by: Edward Wertz <edward@swirldslabs.com>
…twork

# Conflicts:
#	platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/util/BootstrapUtils.java
Signed-off-by: Edward Wertz <edward@swirldslabs.com>
Signed-off-by: Edward Wertz <edward@swirldslabs.com>
Signed-off-by: Edward Wertz <edward@swirldslabs.com>
Signed-off-by: Edward Wertz <edward@swirldslabs.com>
…twork

# Conflicts:
#	hedera-node/hedera-app/src/main/java/com/hedera/node/app/ServicesMain.java
#	platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/Browser.java
#	platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/config/PlatformConfigurationExtension.java
#	platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/util/BootstrapUtils.java
Signed-off-by: Edward Wertz <edward@swirldslabs.com>
Signed-off-by: Edward Wertz <edward@swirldslabs.com>
Signed-off-by: Nathan Klick <nathan@swirldslabs.com>
Signed-off-by: Nathan Klick <nathan@swirldslabs.com>
Signed-off-by: Nathan Klick <nathan@swirldslabs.com>
edward-swirldslabs and others added 4 commits January 7, 2025 20:26
…DiskStartupNetworks.java

Co-authored-by: Matt Hess <matt.hess@swirldslabs.com>
Signed-off-by: Edward Wertz <123979964+edward-swirldslabs@users.noreply.github.com>
Signed-off-by: Edward Wertz <edward@swirldslabs.com>
@edward-swirldslabs edward-swirldslabs added this to the v0.59 milestone Jan 8, 2025
@edward-swirldslabs edward-swirldslabs self-assigned this Jan 8, 2025
@edward-swirldslabs edward-swirldslabs requested a review from a team as a code owner January 8, 2025 04:29
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 67.31%. Comparing base (70c450e) to head (7c9e1fc).

Files with missing lines Patch % Lines
...rc/main/java/com/hedera/node/app/ServicesMain.java 66.66% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #17262      +/-   ##
============================================
+ Coverage     67.24%   67.31%   +0.06%     
- Complexity    21991    22010      +19     
============================================
  Files          2583     2583              
  Lines         96307    96311       +4     
  Branches      10054    10054              
============================================
+ Hits          64763    64832      +69     
+ Misses        27839    27768      -71     
- Partials       3705     3711       +6     
Files with missing lines Coverage Δ
...java/com/swirlds/platform/util/BootstrapUtils.java 17.98% <100.00%> (+10.73%) ⬆️
...rc/main/java/com/hedera/node/app/ServicesMain.java 30.98% <66.66%> (+23.79%) ⬆️

... and 15 files with indirect coverage changes

Impacted file tree graph

Copy link

codacy-production bot commented Jan 8, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.08% (target: -1.00%) 85.71%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (70c450e) 96090 68316 71.10%
Head commit (7c9e1fc) 96094 (+4) 68391 (+75) 71.17% (+0.08%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17262) 7 6 85.71%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@edward-swirldslabs edward-swirldslabs changed the title chore: 17261 restore services main test.java chore: restore ServicesMainTest.java Jan 8, 2025
Signed-off-by: Edward Wertz <edward@swirldslabs.com>
Signed-off-by: Edward Wertz <edward@swirldslabs.com>
Signed-off-by: Edward Wertz <edward@swirldslabs.com>
@edward-swirldslabs edward-swirldslabs requested a review from a team as a code owner January 8, 2025 15:32
timo0
timo0 previously approved these changes Jan 8, 2025
nathanklick
nathanklick previously approved these changes Jan 8, 2025
mhess-swl
mhess-swl previously approved these changes Jan 8, 2025
Copy link
Member

@mhess-swl mhess-swl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for plowing through this @edward-swirldslabs!

edward-swirldslabs and others added 2 commits January 8, 2025 17:27
Signed-off-by: Edward Wertz <edward@swirldslabs.com>
Signed-off-by: Edward Wertz <edward@swirldslabs.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restore ServicesMainTest.java
4 participants