Drop checksum headers + Improve error messages #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some non-MinIO services that can use this plugin do not support `x-amz-checksum-algorithm` and/or `x-amz-checksum-sha256`. Important to note that if a SHA256 checksum still comes through in the response, the existing code will verify that it matches what we have locally.
Current `errorToStatus` is not displaying the underlying error if the status code is 400. Additionally, we are sending the error into this function twice: Once in the error message and again in the error itself. This commit changes the way `errorToStatus` works by sending a message indicating where the error occured and then the actual error as a different argument. Additionally, it changes `errorToStatus` to always print the input message and the error regardless of error type.
louisruch
approved these changes
Oct 1, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.