Fix unknown permission issue with credential-store #1524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimlambrt
previously approved these changes
Sep 13, 2021
jefferai
force-pushed
the
jeff-fix-credstore-grant-validity
branch
from
7562222 to
e560483
Compare
jefferai
force-pushed
the
jeff-fix-credstore-grant-validity
branch
from
e560483 to
6b8f6c6
Compare
jefferai
force-pushed
the
jeff-fix-credstore-grant-validity
branch
from
6b8f6c6 to
eb767b4
Compare
jefferai
force-pushed
the
jeff-fix-credstore-grant-validity
branch
from
eb767b4 to
fae4e9f
Compare
jimlambrt
previously approved these changes
Sep 13, 2021
ghost
previously approved these changes
Sep 13, 2021
This also affected credential libraries and managed groups. It seems that any end-to-end tests of these grants currently had them included in wildcards instead of individually, but these types were never added to the valid list for resources. Additionally, credential store wasn't added as a valid top level type for pinning purposes.
jefferai
force-pushed
the
jeff-fix-credstore-grant-validity
branch
from
fae4e9f to
1ae142c
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also affected credential libraries and managed groups. It seems
that any end-to-end tests of these grants currently had them included in
wildcards instead of individually, but these types were never added to
the valid list for resources. Additionally, credential store wasn't
added as a valid top level type for pinning purposes.