Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(config): Add env and file support to Controller description #1766

Merged
merged 2 commits into from
Dec 8, 2021

Conversation

irenarindos
Copy link
Collaborator

No description provided.

@hashicorp-cla
Copy link

hashicorp-cla commented Dec 7, 2021

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the core label Dec 7, 2021
Copy link
Collaborator

@hugoghx hugoghx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your first PR! :D

internal/cmd/config/config_test.go Outdated Show resolved Hide resolved
internal/cmd/config/config_test.go Show resolved Hide resolved
hugoghx
hugoghx previously approved these changes Dec 7, 2021
Copy link
Collaborator

@hugoghx hugoghx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 !

@irenarindos irenarindos force-pushed the irenarindos-env-file-controllerconfig branch from 242bfd2 to 28e1d62 Compare December 7, 2021 18:53
@irenarindos irenarindos marked this pull request as ready for review December 7, 2021 18:54
hugoghx
hugoghx previously approved these changes Dec 7, 2021
hugoghx
hugoghx previously approved these changes Dec 7, 2021
hugoghx
hugoghx previously approved these changes Dec 8, 2021
@irenarindos irenarindos merged commit ae4aff8 into main Dec 8, 2021
@irenarindos irenarindos deleted the irenarindos-env-file-controllerconfig branch December 8, 2021 13:28
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants