Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Update authenticate command/subcommands help text #1835

Merged
merged 1 commit into from
Jan 31, 2022
Merged

Update authenticate command/subcommands help text #1835

merged 1 commit into from
Jan 31, 2022

Conversation

jefferai
Copy link
Member

  • Make it clear in the subcommands that the given strings are examples
  • Add an OIDC example to show that there are different types
  • Remove password flag from examples

Closes #1833

@jefferai jefferai added this to the 0.7.5 milestone Jan 31, 2022
@github-actions github-actions bot added the core label Jan 31, 2022
@jefferai
Update authenticate command/subcommands help text
25ca7f4 
* Make it clear in the subcommands that the given strings are examples
* Add an OIDC example to show that there are different types
* Remove password flag from examples
irenarindos
irenarindos approved these changes Jan 31, 2022
View reviewed changes
Copy link
Collaborator

@irenarindos irenarindos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

hugoghx
hugoghx approved these changes Jan 31, 2022
View reviewed changes
Copy link
Collaborator

@hugoghx hugoghx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jefferai jefferai mentioned this pull request Jan 31, 2022
Closed
@jefferai jefferai merged commit 5743580 into main Jan 31, 2022
@jefferai jefferai deleted the issue-1833 branch January 31, 2022 16:50
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@irenarindos irenarindos irenarindos approved these changes

@hugoghx hugoghx hugoghx approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
0.7.5
Development

Successfully merging this pull request may close these issues.

boundary authenticate (type) can conflict with BOUNDARY_AUTH_METHOD_ID
3 participants
@jefferai @irenarindos @hugoghx