fix(controller/targets): authorize-session should allow h_ ids

[justenwalker]

The targets controller previously only allowed hosts from a static catalog
since it checked for the ID subtype from the static package.

This change validates host ids with the plugin.Subtype as well

Fixes: #1850

[talanknight]

Thank you for the fix!
Currently our target_service test doesn't cover specifying the host id when authorizing a session so I'll submit a seperate fast follow up PR to this one which adds regression tests.

[justenwalker]

Thank you for the fix! Currently our target_service test doesn't cover specifying the host id when authorizing a session so I'll submit a seperate fast follow up PR to this one which adds regression tests.

Hi @talanknight -- I have an update coming which should add a regression test for this case - I can push it to this PR if you're interested

diff --git a/internal/servers/controller/handlers/targets/tcp/target_service_test.go b/internal/servers/controller/handlers/targets/tcp/target_service_test.go
index 6424d9b8..0d90f182 100644
--- a/internal/servers/controller/handlers/targets/tcp/target_service_test.go
+++ b/internal/servers/controller/handlers/targets/tcp/target_service_test.go
@@ -2776,6 +2776,12 @@ func TestAuthorizeSession(t *testing.T) {
                        assert.NotEmpty(t, cmp.Diff(asRes1.GetItem().GetCredentials(), asRes2.GetItem().GetCredentials(), protocmp.Transform()),
                                "the credentials aren't unique per request authorized session")

+                       _, err = s.AuthorizeSession(ctx, &pbs.AuthorizeSessionRequest{
+                               Id:     tar.GetPublicId(),
+                               HostId: asRes2.GetItem().GetHostId(),
+                       })
+                       require.NoError(t, err, "session must authorize with explicit host ID")
+
                        wantedHostId := tc.wantedHostId
                        if tc.wantedHostId == "?" {
                                wantedHostId = asRes2.GetItem().GetHostId()

[talanknight]

Adding that regression test would be wonderful. Thank you!

[justenwalker]

Adding that regression test would be wonderful. Thank you!

Sure thing. Pushed for your review.

[talanknight]

Looks good!