Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

bug(worker): create error and handle session cancel with no tofu token #1929

Merged
merged 1 commit into from
Mar 17, 2022

Conversation

irenarindos
Copy link
Collaborator

  • Create new error if no tofu token found to prevent event.newError: missing error: invalid parameter
  • Handle session cancellation before tofu token, to fix error where session was cancelled without making a connection (erred on no tofu token)

Fixes #1902

CHANGELOG.md Outdated
@@ -3,6 +3,10 @@
Canonical reference for changes, improvements, and bugfixes for Boundary.

## Next
### Bug Fixes
* worker: create new error to prevent `event.newError: missing error: invalid parameter` and handle session cancel
with no tofu token ([Issue](https://github.com/hashicorp/boundary/issues/1902),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
with no tofu token ([Issue](https://github.com/hashicorp/boundary/issues/1902),
with no TOFU token ([Issue](https://github.com/hashicorp/boundary/issues/1902),

jefferai
jefferai previously approved these changes Mar 17, 2022
@irenarindos irenarindos force-pushed the irindos-worker-handler-bug branch from 5b9a5b5 to 0eb70b7 Compare March 17, 2022 13:18
@irenarindos irenarindos merged commit 49e904f into main Mar 17, 2022
@irenarindos irenarindos deleted the irindos-worker-handler-bug branch March 17, 2022 13:31
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ERROR] event.WriteError: event.newError: missing error: invalid parameter
2 participants