bug(session): null fkey trigger also checks for session terminated state #2065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgaffney
reviewed
May 9, 2022
| -- cancel_session will insert a cancel state for the session, if there's isn't | ||
| -- a canceled or terminated state already. It's used by cancel_session_with_null_fk. | ||
| create function | ||
| cancel_session(in sessionId text) returns void |
There was a problem hiding this comment.
Can we add unit tests for this?
There was a problem hiding this comment.
Sorry, I should have been more clear. I was thinking the unit tests would be added to our sql test suite since this is a sql function. Would it be possible to add unit tests there?
There was a problem hiding this comment.
Sorry about that! I've added internal/db/sqltest/tests/session/delete_session_target.sql
irenarindos
force-pushed
the
irindos-session-nullfkey
branch
2 times, most recently
from
cfcae0b to
8b9e2d9
Compare
mgaffney
previously approved these changes
May 12, 2022
irenarindos
force-pushed
the
irindos-session-nullfkey
branch
from
8b9e2d9 to
54c30d2
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Function cancel_session() cancels sessions on deletion of foreign key constraints. It checked whether a session was in a canceling state but not terminated (sessions can transition to terminated without going through canceling).
This update adds a check for a terminated state to prevent attempts to cancel already terminated sessions.
Fixes #2064