Propagate plugin execution dir to CreatePlugin #2183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanbrandhorst
changed the title
johanbrandhorst
force-pushed
the
jbrandhorst-plugin-execution-dir-propagation
branch
3 times, most recently
from
d2894ed to
f8ce116
Compare
Plugin options were previously only applied to the BuildPluginMap call, resulting in the plugin execution_dir variable being ineffective. Also add a test to verify functionality
johanbrandhorst
force-pushed
the
jbrandhorst-plugin-execution-dir-propagation
branch
from
f8ce116 to
ae912db
Compare
johanbrandhorst
changed the title
Previously, only external host plugins would respect the plugin execution dir. Now, all uses of the embedded plugins respect the configuration.
johanbrandhorst
force-pushed
the
jbrandhorst-plugin-execution-dir-propagation
branch
from
ae912db to
a4ffe7c
Compare
jefferai
approved these changes
Jun 15, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: Propagate plugin options to CreatePlugin
Plugin options were previously only applied to the
BuildPluginMap call, resulting in the plugin
execution_dir variable being ineffective.
Also add a test to verify functionality
fix: Support plugin execution_dir for all plugins
Previously, only external host plugins would respect
the plugin execution dir. Now, all uses of the embedded
plugins respect the configuration.